Mock getJsonSizeUnsafe to speed up tests
#2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 476 476
Lines 10137 10137
Branches 1542 1542
=======================================
Hits 9565 9565
Misses 572 572 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/mock-json-size
branch
from
69fe568 to
999ffc0
Compare
GuillaumeRx
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface controller uses
getJsonSizeUnsafeto determine the size of an interface object. For some reason this takes a long time for large legacy UI components, especially in CI.