Move onSettingsPage example to Preinstalled example snap
#2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/move-settings-to-preinstalled
branch
from
1d9628d to
0dc7ae6
Compare
packages/examples/packages/preinstalled/src/components/settings.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 489 489
Lines 10490 10490
Branches 1609 1609
=======================================
Hits 9915 9915
Misses 575 575 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
settings-page-example-snapand moves its logic to thepreinstalled-example-snapsince this handler is restricted to preinstalled snaps for now.