Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSP #159

Closed
wants to merge 2 commits into from
Closed

Add CSP #159

wants to merge 2 commits into from

Conversation

Pandapip1
Copy link

@Pandapip1 Pandapip1 commented Mar 30, 2022 •
edited
Loading

No description provided.

@Pandapip1 Pandapip1 requested a review from a team as a code owner March 30, 2022 12:44
@mcmire
Copy link
Collaborator

mcmire commented Mar 30, 2022

Would you mind explaining why you're submitting this PR and what problem this solves?

@Pandapip1
Copy link
Author

Sure! See MetaMask/metamask-extension#14233, MetaMask/detect-provider#31, and MetaMask/metamask-extension#3133. This PR will result in CircleCI test cases failing if Metamask cannot inject due to the CSP.

@mcmire
Copy link
Collaborator

mcmire commented Mar 31, 2022 •
edited
Loading

Okay cool. I'd seen some CSP stuff come through elsewhere, I wasn't sure if it was related or not. We'll take a look :)

@Pandapip1 Pandapip1 closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pandapip1 @mcmire