Rename BitcoinUrlBuilder to BitcoinUriBuilder

[kristapsk]

BIP21 contains URIs, not URLs, this is correct terminology (every URL is URI, but not every URI is URL).

Original discussion - #138 (comment).

[knocte]

utACK, however, @kristapsk unfortunately this PR needs to be rebased

[kristapsk]

Rebased.

Tests pass, but, please, review again.

[NicolasDorier]

I am on the fence for this one. This might requires a major release as it's a breaking change.

[knocte]

as it's a breaking change.

Are you sure? Previous consumers of the API will still work because he left a type called BitcoinUrlBuilder there. Only things that NBitcoin consumers will notice is some Obsolete warnings.

[augustoproiete]

as it's a breaking change.

Are you sure? Previous consumers of the API will still work because he left a type called BitcoinUrlBuilder there. Only things that NBitcoin consumers will notice is some Obsolete warnings.

It's a binary breaking change for sure. The old class now inherits from the new class, so it's no longer the same type across different versions of NBitcoin, so if this were to be merged, it should be released with a major version bump.

An easy way to solve this would be remove the inheritance and use encapsulation instead... Just forwarding all the methods in the old class, to the new class... That would allow for a smooth minor version bump.

[NicolasDorier]

@kristapsk can you take simpler approach, not breaking anything: Just leave the BitcoinUrlBuilder as it was before, just add the [Obsolete] attribute like you did. No inheritance.

Then just duplicate the code for BitcoinUriBuilder. I will eventually remove BitcoinUrlBuilder in a major release.

Would fix breaking change @augustoproiete pointed out.

[kristapsk]

@NicolasDorier Ok, will do that!