Skip to content

Generate and suggest key factors #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 14, 2025
Merged

Generate and suggest key factors #2694

merged 21 commits into from
May 14, 2025

Conversation

elisescu
Copy link
Contributor

@elisescu elisescu commented May 2, 2025

This is a combination of multiple commits, maybe easiest to review independently

@elisescu elisescu requested a review from hlbmtc May 2, 2025 08:11
@elisescu elisescu requested a review from ncarazon May 2, 2025 08:12
@elisescu elisescu removed request for ncarazon and hlbmtc May 2, 2025 10:49
elisescu added 21 commits May 14, 2025 09:16
If the user has created Key Factors in the past, show a modal with
suggested key factors when the user posts a new comment
Seems to crash natively when running on prod and have no idea why

The list of a more advanced model seems to cause a native crash
somewhere inside instructor
- Include all post key factors when in asking the LLM to suggest new ones
- Ask the LLM to not suggest duplicates
- Extract the key factors addition logic in a reusable hook
- Make the form form a public component
@elisescu elisescu merged commit 9fb6fe5 into main May 14, 2025
4 checks passed
@elisescu elisescu deleted the llm_keyfactors branch May 14, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants