Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show HUD In Editor #5077

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Show HUD In Editor #5077

merged 3 commits into from
Jan 3, 2025

Conversation

machiecodes
Copy link
Contributor

Type of change

  • Bug fix
  • New feature

Description

Breaking change moment, added a boolean showHUDInEditor() to GuiTheme class for themes to implement, allowing the minecraft hud to always be shown in the meteor hud editor regardless of whether hide hud is on.

Related issues

N/A

How Has This Been Tested?

Opened in singleplayer world 👍

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

Adds a setting to always show the minecraft hud when using the meteor hud editor
@RacoonDog
Copy link
Contributor

i'm also unsure whether this should be part of a theme at all or just a setting in the meteor client Config system, considering it doesn't affect anything in the meteor widget rendering

Good feature so why put in setting :3
@tyrannus00
Copy link
Contributor

This implementation doesn't toggle the hud off again, after leaving the editor

@Wide-Cat
Copy link
Collaborator

Wide-Cat commented Jan 2, 2025

as tyr said

Oversight :3
@Wide-Cat Wide-Cat merged commit b67a9b4 into MeteorDevelopment:master Jan 3, 2025
1 check passed
@machiecodes machiecodes deleted the show-hud branch January 3, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants