Refactor Sprint #5078
Merged
Refactor Sprint #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the jump fix a base part of rage mode
Why was this ever a feature lol
also clean up warnings in LivingEntityMixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Make the jump fix a part of rage and remove the "always sprinting" logic. Evidently the logic behind "Rage" is to be sprinting at any time possible, it's unlikely for a server's AC to be configured in such a way that it ignores backwards jumping but just lets you keep sprinting after you hit a block.
As for always sprinting, it's really just a useless feature that makes sprint flag more on most anticheats. Functionally it makes no difference if this is removed so I figure it's all upsides.
Related issues
N/A
How Has This Been Tested?
Joining minehut through both IDE and a Prism instance and running around a bit, running into walls, testing omnidirectional movement, etc.
Checklist: