Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom Hide Hud Setting #5080

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

machiecodes
Copy link
Contributor

@machiecodes machiecodes commented Jan 2, 2025

Type of change

  • Bug fix
  • New feature

Description

Adds a setting to hide the hud while the module is active. Activating this hides the "show hands" setting since that logic is encapsulated in hud rendering. If the user manually turns the hud on/off while the module is active it will not try to retoggle the hud when deactivated.

Related issues

N/A

How Has This Been Tested?

2025-01-02.15-13-26.mp4

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat
Copy link
Collaborator

Wide-Cat commented Jan 3, 2025

the mouse button event can probably be removed, i dont think its possible for a mouse to call GLFW_KEY_F1 and for it to show up in that event

@machiecodes
Copy link
Contributor Author

Fair enough, I was just thinking of like razer software stuff that lets you rebind keys to diff things but I also guess people wouldn't be rebinding hide hud to anything without a mod lol

machiecodes and others added 2 commits January 2, 2025 19:29
Mice cannot call GLFW_KEY_F1 unless they use a cell phone :3
@Wide-Cat Wide-Cat merged commit 40cfef1 into MeteorDevelopment:master Jan 3, 2025
1 check passed
@machiecodes machiecodes deleted the zoom-hide-hud branch January 3, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants