Hide Modules in ClickGUI #5081
Open
Hide Modules in ClickGUI #5081
+27
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machiecodes
force-pushed
the
hide-modules
branch
from
c721a44 to
604609f
Compare
Better to show modules all the time for an easy way to tweak settings without going through the hiding process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds a new "modules" category in the config where module search settings were moved, along with a new "hidden modules" setting. You can add modules to this list and they will be excluded from the modules screen when entering the clickgui. They are not actually removed to keep compatability with mixins, addons etc, but are simply kept out of sight. Should be useful for hiding bloat in addons or modules you don't plan to use.
I don't think there needs to be any optimization here? Just wary of o(n^2) stuff but at least in this case it only happens once when the screen is created and there's a small enough amount of modules that I don't believe it makes a difference - at least it doesn't on my laptop. Maybe Crosby will prove me wrong in the future :3
Related issues
#3454, #726
How Has This Been Tested?
8mb.video-o5X-XdN9pTfU.mp4
Checklist: