Skip to content

Remove usage of java.util.Stack #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Remove usage of java.util.Stack #5800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main/java/meteordevelopment/meteorclient/gui/renderer/GuiRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

package meteordevelopment.meteorclient.gui.renderer;

import it.unimi.dsi.fastutil.Stack;
import it.unimi.dsi.fastutil.objects.ObjectArrayList;
import meteordevelopment.meteorclient.MeteorClient;
import meteordevelopment.meteorclient.gui.GuiTheme;
import meteordevelopment.meteorclient.gui.renderer.operations.TextOperation;
Expand All @@ -22,9 +24,7 @@
import net.minecraft.util.Identifier;
import net.minecraft.util.math.MathHelper;

import java.util.ArrayList;
import java.util.List;
import java.util.Stack;

import static meteordevelopment.meteorclient.MeteorClient.mc;
import static meteordevelopment.meteorclient.utils.Utils.getWindowHeight;
Expand All @@ -49,12 +49,12 @@ public class GuiRenderer {
private final Renderer2D rTex = new Renderer2D(true);

private final Pool<Scissor> scissorPool = new Pool<>(Scissor::new);
private final Stack<Scissor> scissorStack = new Stack<>();
private final Stack<Scissor> scissorStack = new ObjectArrayList<>();

private final Pool<TextOperation> textPool = new Pool<>(TextOperation::new);
private final List<TextOperation> texts = new ArrayList<>();
private final List<TextOperation> texts = new ObjectArrayList<>();

private final List<Runnable> postTasks = new ArrayList<>();
private final List<Runnable> postTasks = new ObjectArrayList<>();

public String tooltip, lastTooltip;
public WWidget tooltipWidget;
Expand Down Expand Up @@ -141,7 +141,7 @@ public void endRender(Scissor scissor) {

public void scissorStart(double x, double y, double width, double height) {
if (!scissorStack.isEmpty()) {
Scissor parent = scissorStack.peek();
Scissor parent = scissorStack.top();

if (x < parent.x) x = parent.x;
else if (x + width > parent.x + parent.width) width -= (x + width) - (parent.x + parent.width);
Expand Down Expand Up @@ -253,7 +253,7 @@ public void texture(double x, double y, double width, double height, double rota
}

public void post(Runnable task) {
scissorStack.peek().postTasks.add(task);
scissorStack.top().postTasks.add(task);
}

public void item(ItemStack itemStack, int x, int y, float scale, boolean overlay) {
Expand Down