Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda Lock Upgrades - Part 1 #47

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conda Lock Upgrades - Part 1 #47

merged 4 commits into from
Sep 19, 2024

Conversation

jbouder
Copy link
Contributor

@jbouder jbouder commented Sep 19, 2024

The purpose of this PR is to upgrade conda-lock and supporting packages to the latest supported versions, with the least disruption to the project.

Follow-on updates will include a full upgrade of conda-lock, which will require the upgrade to pydantic v2. These changes have more affects on the code-base.

Description

Related Issue

N/A

Motivation and Context

  • Project Modernization
  • Upgrade to more secure packages

How Has This Been Tested?

  • Local Testing

Screenshots (if appropriate):

@jbouder jbouder added the dependencies Update to some package/dependency label Sep 19, 2024
Copy link

@ericdatakelly ericdatakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbouder I think the code has some bugs. There's one about installation, but I don't know the answer off hand so would need to discuss it.

.github/workflows/test.yml Outdated Show resolved Hide resolved
environment.yaml Show resolved Hide resolved
environment.yaml Show resolved Hide resolved
setup.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/test_integration.py Show resolved Hide resolved
Copy link

@ericdatakelly ericdatakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbouder jbouder merged commit b063cf3 into main Sep 19, 2024
3 checks passed
@jbouder jbouder deleted the upgrades-1 branch September 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update to some package/dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants