Update instructions for GitHub API tokens #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kini
force-pushed
the
update-github-api-token-instructions
branch
from
4413c67 to
430ddca
Compare
README.md
Outdated
Comment on lines
229
to
230
| Otherwise, you'll have to manually create a "personal access token (classic)" | ||
| through the GitHub website. See [the GitHub documentation][3] for |
There was a problem hiding this comment.
Suggested change
| Otherwise, you'll have to manually create a "personal access token (classic)" | |
| through the GitHub website. See [the GitHub documentation][3] for | |
| Otherwise, you'll have to create a "personal access token (classic)" | |
| through GitHub's website. See [the GitHub documentation](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#personal-access-tokens-classic) for |
kini
force-pushed
the
update-github-api-token-instructions
branch
from
430ddca to
8b1f30a
Compare
asymmetric
added a commit
to asymmetric/nixpkgs-review
that referenced
this pull request
Sep 18, 2024
Minimal version of Mic92#406
SuperSandro2000
added a commit
that referenced
this pull request
Sep 18, 2024
* doc: mention that only classic PATs work Minimal version of #406 * doc: update example token PATs have a `ghp_` prefix now. * doc: fix formatting Co-authored-by: Sandro <[email protected]> --------- Co-authored-by: Sandro <[email protected]>
|
Can this be closed now? |
|
Why? There are still plenty of changes in it that weren't uptaken in 2beefeb. |
kini
force-pushed
the
update-github-api-token-instructions
branch
from
8b1f30a to
73ea2b2
Compare
|
Rebased on top of 2beefeb. I'd appreciate it if someone could reply to the pending review comments above. |
In late 2022, GitHub [introduced][1] a new type of API tokens that are supposed to be more secure and fine grained than the old type of tokens. But they won't work for nixpkgs-review's purposes (at least for now) because there is no way to grant these new tokens access to resources that are not owned by you, and most users of nixpkgs-reviews are not owners of @NixOS/nixpkgs which is the repo they're trying to submit pull request comments to (when using `--post-result`, anyway). This commit clarifies the README instructions so that users will know they need to create the old type of API token, the "personal access token (classic)", and not the new type. Also did a bit of rewording for further clarity. [1]: https://github.blog/2022-10-18-introducing-fine-grained-personal-access-tokens-for-github/
Mic92
force-pushed
the
update-github-api-token-instructions
branch
from
4cef96c to
86940d1
Compare
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In late 2022, GitHub introduced a new type of API tokens that are supposed to be more secure and fine grained than the old type of tokens. But they won't work for nixpkgs-review's purposes (at least for now) because there is no way to grant these new tokens access to resources that are not owned by you, and most users of nixpkgs-reviews are not owners of @NixOS/nixpkgs which is the repo they're trying to submit pull request comments to (when using
--post-result, anyway).This commit clarifies the README instructions so that users will know they need to create the old type of API token, the "personal access token (classic)", and not the new type.
Also did a bit of rewording for further clarity.