Update argument handling #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start the migration to only using namespaced flag names. - Log deprecation warnings for anyone relying on the old behaviour. - Take advantage of argparse functionality in the new flags, because flake8 has migrated away from optparse. - Update readme accordingly # Conflicts: # flake8_spellcheck/__init__.py
|
Yes, bumping the major and updating the docs would be the best approach. |
djmattyg007
reviewed
Mar 26, 2022
djmattyg007
reviewed
Mar 26, 2022
README.rst
Outdated
| You can whitelist words that are specific to your project simply by adding them to ``whitelist.txt`` | ||
| in the root of your project directory. Each word you add should be separated by a newline. | ||
| You can whitelist words that are specific to your project simply by adding them to ``spellcheck-allowlist.txt`` | ||
| in the root of your project directory. Each word you add should be separated by a newline. | ||
|
|
||
| Spelling is assumed to be in en_US. | ||
|
|
||
| This plugin supports python 3.6+ |
There was a problem hiding this comment.
This note about Python version support is no longer accurate, right? I thought I saw that support for Python 3.6 has been dropped.
There was a problem hiding this comment.
Yep you need to rebase :)
…andling # Conflicts: # flake8_spellcheck/__init__.py
…dling # Conflicts: # flake8_spellcheck/__init__.py
|
I totally missed that you moved to 'main' (excellent BTW). I think the PR is accurate again. But it definitely needs some testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 has migrated away from optparse.
Further cherry picking from #55.