Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add failing test #82

Merged
merged 1 commit into from
Oct 12, 2019
Merged

add failing test #82

merged 1 commit into from
Oct 12, 2019

Conversation

benwaffle
Copy link
Contributor

issue #79

@benwaffle
Copy link
Contributor Author

:( i was hoping circleci would run. @MichaelAquilina can you run it?

@MichaelAquilina
Copy link
Owner

That's strange. Will see what's going on

@MichaelAquilina
Copy link
Owner

@benwaffle I've enabled builing on forked pull requests. Could you try git commit --amend and then git push -f?

@benwaffle
Copy link
Contributor Author

no build :(

@MichaelAquilina
Copy link
Owner

Building now :)

@benwaffle
Copy link
Contributor Author

Does that give you enough info to reproduce the bug?

@MichaelAquilina MichaelAquilina changed the base branch from master to next October 12, 2019 22:43
@MichaelAquilina
Copy link
Owner

yes @benwaffle thanks for the PR. I'll merge this in and use it to investigate

@MichaelAquilina MichaelAquilina merged commit 98d0927 into MichaelAquilina:next Oct 12, 2019
@benwaffle benwaffle deleted the test-79 branch October 12, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwaffle @MichaelAquilina