File upload on mobile #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MichalBryxi
commented
Sep 25, 2024
•
MichalBryxi
commented
- Had to hunt down ugly bugs 1, 2, 3 in ember-file-upload first.
- Added a file input for devices that don't support drag & drop.
- Better would be to have both, but working with input file is PITA.
- Some aesthetic niceties.
- Drop area disappears when used. We assume only one picture being used at a time.
- Fixes File upload on click #1
- One image is the most common use-case - The drop zone obstructs view to toggles otherwise - It's still possible to drop multiple images if you wish
✅ Deploy Preview for open-to-dot-dot-dot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.