Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using this module in a Chrome extension #17

Closed
mahfoozm opened this issue Dec 24, 2022 · 2 comments · Fixed by #22 · May be fixed by #23
Closed

Using this module in a Chrome extension #17

mahfoozm opened this issue Dec 24, 2022 · 2 comments · Fixed by #22 · May be fixed by #23

Comments

@mahfoozm
Copy link

mahfoozm commented Dec 24, 2022 •
edited
Loading

Hi, I'm working on a chrome extension to display a professors rating on my universities course portal, but I'm having trouble with the implementation, and was wondering if I was missing an obvious detail.

Problem: https://stackoverflow.com/questions/74905140/am-i-including-npm-modules-in-my-chrome-extension-correctly

Repository: https://github.com/mahfoozm/YorkURMP

Thanks!
@codetheweb
Copy link
Member

It sounds like this package is working correctly and there's a problem with your bundling setup. Unfortunately I'm not super familiar with building extensions so I can't help much, sorry.

@njerig
Copy link
Contributor

njerig commented Apr 2, 2023 •
edited
Loading

I get the following error when I use this from my Chrome extension:

Uncaught (in promise) ReferenceError: XMLHttpRequest is not defined
at browser-ponyfill.js:462:1

This is coming from graphql-request using cross-fetch. (Evidence: when I add fetch to the GraphQLClient options object, the error disappears.)

This was referenced Apr 2, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@njerig @codetheweb @mahfoozm