Use global fetch if in browser environment, else use cross-fetch #23
+7,173
−711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isomorphic-fetch uses the same browser polyfill as cross-fetch and therefore returns the same error. isomorphic-fetch will be removed as a dependency in the next commit. Related pull request that was never merged: lquixada/cross-fetch#138
codetheweb
reviewed
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isomorphic-fetch uses the same browser polyfill as cross-fetch and therefore shouldn't be used if graphql-request already uses cross-fetch. Instead, we check to see whether the global fetch defined in browsers exists. If it does, we use it; if it doesn't, we use cross-fetch.
Resolves: #17
Related pull request that was never merged: lquixada/cross-fetch#138