Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workbooks-bring-your-own-storage.md #66

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

vutran01
Copy link
Contributor

@vutran01 vutran01 commented Dec 9, 2024

Update docs to reflect limitation that worbooks supports user assigned managed identities and does not work with system assigned managed identities

Update docs to reflect limitation that worbooks supports user assigned managed identities and does not work with system assigned managed identities
Copy link
Contributor

@vutran01 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 2eab3e8:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-monitor/visualize/workbooks-bring-your-own-storage.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Dec 9, 2024

@AbbyMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Dec 9, 2024
Copy link
Contributor

@AbbyMSFT AbbyMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vutran01,
Just checking - you added this note to the page on BYOS. Was it your intention to only add this limitation for BYOS or for all of workbooks?

If it just for BYOS, then I approve. and you can sign off.
Thanks,
Abby

@vutran01
Copy link
Contributor Author

Hi @vutran01, Just checking - you added this note to the page on BYOS. Was it your intention to only add this limitation for BYOS or for all of workbooks?

If it just for BYOS, then I approve. and you can sign off. Thanks, Abby

Managed identities are only applicable when saving to customer storage. There are two types of managed identities User Assigned and System Assigned, and I wanted to call out that Workbooks only supports User Assigned. In the portal (and the above docs), User Assigned is used. Users could try to use System Assigned using powershell or CLI but they would get failures for when doing that. If there's a better way to document this so user won't try the unsupported path, that would be great.

Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Dec 24, 2024
@v-dirichards
Copy link
Contributor

@AbbyMSFT I'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request.

@v-dirichards v-dirichards merged commit ae364ee into MicrosoftDocs:main Jan 15, 2025
2 checks passed
@AbbyMSFT
Copy link
Contributor

AbbyMSFT commented Jan 15, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants