-
Notifications
You must be signed in to change notification settings - Fork 540
Change "Get started PWAs" tut to code expl + steps to use sample #3476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 8c69f1d: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit 45fd8a7: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
<!-- todo: new: | ||
[App](https://microsoftedge.github.io/Demos/pwa-installer/), [source code and Readme file](https://github.com/MicrosoftEdge/Demos/tree/main/pwa-installer/). | ||
--> | ||
Original version:<!-- todo: which should the user use? why 2 dirs? --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to /pwastore/, /pwa-installer/, or both?
Web Install is still in Dev Trial. Related to the PWA installer sample, which is probably essentially the same code in both sample dirs:
- /pwastore/ - refered to by the Dev Trial, so must keep during Dev Trial, even though "store" isn't what we want.
- /pwa-installer/ - the newer dir and naming that we want.
The live article
https://learn.microsoft.com/microsoft-edge/progressive-web-apps/demo-pwas#pwa-installer
links to /pwastore/ only, not to /pwa-installer/ - which sample(s) should it link to?
The article should explicitly address this and discuss relationship between the two samples/dirs.
Maybe nowhere mention pwastore, but in its Readme, explain relation between the two samples/dirs.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit 38d1fc0: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
|
||
|
||
<!-- ====================================================================== --> | ||
## Step 12: View the modified web app in the browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Demos repo, rename /pwa-getting-started/ to /temperature-converter/
https://github.com/MicrosoftEdge/Demos/tree/main/pwa-getting-started/ - dir ought to be renamed /temperature-converter/
todo: create a Demos repo PR to rename the dir (after I test the steps in /pwa/samples/temperature-converter/ which will re-clone the Demos repo).
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit cdce6e0: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
Rendered article sections for review:
Sequence of 3 related articles in TOC:

Use PWAs in Microsoft Edge
/progressive-web-apps/ux.md
(~/)Get started developing a PWA
/progressive-web-apps/how-to/index.md
(/how-to/)Temperature convertor sample
/progressive-web-apps/samples/temperature-converter.md
(/samples/)Articles (.md files) outside the PWA bucket
same order as Files Changed
Top of TOC
DevTools
Extensions
Hub page
PWA
TOC
more DevTools
WebView2
Testing redirects before merge
Old url paths (not listing older versions of paths):
1 - DevTools
url to test:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/sample-code/sample-code?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/devtools/samples/?branch=pr-en-us-3476
2 - DevTools
url to test:
https://review.learn.microsoft.com/microsoft-edge/devtools/sample-code/sample-code?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/devtools/samples/?branch=pr-en-us-3476
3 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part1-simple-extension?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/picture-viewer-popup-webpage?branch=pr-en-us-3476
4 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/picture-viewer-popup-webpage?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/picture-viewer-popup-webpage?branch=pr-en-us-3476
5 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions/getting-started/picture-viewer-popup-webpage?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/picture-viewer-popup-webpage?branch=pr-en-us-3476
6 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/picture-inserter-content-script?branch=pr-en-us-3476&tabs=gitbash
7 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/picture-inserter-content-script?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/picture-inserter-content-script?branch=pr-en-us-3476&tabs=gitbash
8 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions/getting-started/picture-inserter-content-script?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/picture-inserter-content-script?branch=pr-en-us-3476&tabs=gitbash
9 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/samples?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/?branch=pr-en-us-3476
10 - Extensions
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/extensions/samples/?branch=pr-en-us-3476
11 - PWA
url to test:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/demo-pwas?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps/samples/?branch=pr-en-us-3476
12 - PWA
url to test:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps/demo-pwas?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps/samples/?branch=pr-en-us-3476
13 - WebView2
url to test:
https://review.learn.microsoft.com/microsoft-edge/webview2/code-samples-links?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/webview2/samples/?branch=pr-en-us-3476
14 - WebView2
url to test:
https://review.learn.microsoft.com/microsoft-edge/webview2/concepts/deployment-distribution?branch=pr-en-us-3476
status: ok
end up at:
https://review.learn.microsoft.com/microsoft-edge/webview2/concepts/distribution?branch=pr-en-us-3476&tabs=dotnetcsharp
Testing redirects after merge
AB#54469985