Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "IIS-docs: SFI Image Sev 1-2 Fixes" #1071

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Oct 23, 2024

Reverts #1068

I'm reverting this for now. If the loop-back address isn't on the approved list, we need to get that added.

The pic's deleted with the password obscured shouldn't be deleted without @John-Hart approval. Our mandate is to warn and recommend the most secure authentication flow. IIS Mgr doesn't have a mechanism to store secrets in a key vault AFAIK.

We have too many customers using IIS and IIS Mgr to just delete all those images.

@Rick-Anderson Rick-Anderson requested a review from a team as a code owner October 23, 2024 21:49
@Rick-Anderson
Copy link
Contributor Author

@lextm please review

@Rick-Anderson Rick-Anderson merged commit 28046eb into main Oct 24, 2024
2 checks passed
@Rick-Anderson Rick-Anderson deleted the revert-1068-wadepickett/33750SFIimagesSev02 branch October 24, 2024 16:18
@wadepickett
Copy link
Contributor

@tdykstra and @Rick-Anderson

I don't understand revert reasoning (but need to since I am doing more of these). As stated in #1068 PR the few images deleted were ones verified to be orphans, not actually referenced by any document.

The rest in that PR had specific details removed per the SFI instruction.

@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Oct 24, 2024

What you wrote:

Fixing all SFI severity 1-2 images.
Also, deleting a

few

SFI images where I verified them not to be referenced at all by any document.

I saw more than a few deleted images.

@Rick-Anderson
Copy link
Contributor Author

Delete orphans in a separate PR
otherwise it's too hard to guess the reason something is delete3ed

@wadepickett
Copy link
Contributor

I said why in the PR, you don't have to guess. They were deleted because they were not referenced by any content.

@Rick-Anderson
Copy link
Contributor Author

The orphans weren't identified so I had to guess and there were more than a few. Guessing is not verifying.

Do 2 PR, orphans and another problematic images. State what you will replace the deleted image with

@wadepickett
Copy link
Contributor

wadepickett commented Oct 27, 2024

"State what you will replace the deleted image with"

Rick, I did not delete any images except orphaned images that were not referenced by anything, as I indicated. Orphaned images would not be replaced with anything, since they are orphaned images, images not referenced by any topic.

I am redoing them as seperate PR's right now this weekend.

@fatmasamuk
Copy link

fatmasamuk commented Oct 27, 2024 via email

@fatmasamuk
Copy link

fatmasamuk commented Oct 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants