-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "IIS-docs: SFI Image Sev 1-2 Fixes" #1071
Revert "IIS-docs: SFI Image Sev 1-2 Fixes" #1071
Conversation
This reverts commit 8df9ff5.
@lextm please review |
I don't understand revert reasoning (but need to since I am doing more of these). As stated in #1068 PR the few images deleted were ones verified to be orphans, not actually referenced by any document. The rest in that PR had specific details removed per the SFI instruction. |
What you wrote: Fixing all SFI severity 1-2 images. fewSFI images where I verified them not to be referenced at all by any document. I saw more than a few deleted images. |
Delete orphans in a separate PR |
I said why in the PR, you don't have to guess. They were deleted because they were not referenced by any content. |
The orphans weren't identified so I had to guess and there were more than a few. Guessing is not verifying. Do 2 PR, orphans and another problematic images. State what you will replace the deleted image with |
"State what you will replace the deleted image with" Rick, I did not delete any images except orphaned images that were not referenced by anything, as I indicated. Orphaned images would not be replaced with anything, since they are orphaned images, images not referenced by any topic. I am redoing them as seperate PR's right now this weekend. |
Anldom
28 Eki 2024 Pzt 00:25 tarihinde Wade Pickett ***@***.***>
şunu yazdı:
… "State what you will replace the deleted image *with*"
Rick, I did not delete any images except orphaned images that were not
referenced by anything, as I indicated. Orphaned images would not be
replaced with anything, since they are orphaned image, images not
referenced by any topic. This is kinda making a mountain out of a molehill
when even the molehill did not exist to begin with.
—
Reply to this email directly, view it on GitHub
<#1071 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQCRRDYAFSPQOB57SURAUN3Z5VK5RAVCNFSM6AAAAABQPXZFOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGE4DAMBZHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I don't understand anything
28 Eki 2024 Pzt 00:36 tarihinde fatma samuk ***@***.***> şunu
yazdı:
… Anldom
28 Eki 2024 Pzt 00:25 tarihinde Wade Pickett ***@***.***>
şunu yazdı:
> "State what you will replace the deleted image *with*"
>
> Rick, I did not delete any images except orphaned images that were not
> referenced by anything, as I indicated. Orphaned images would not be
> replaced with anything, since they are orphaned image, images not
> referenced by any topic. This is kinda making a mountain out of a molehill
> when even the molehill did not exist to begin with.
>
> —
> Reply to this email directly, view it on GitHub
> <#1071 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AQCRRDYAFSPQOB57SURAUN3Z5VK5RAVCNFSM6AAAAABQPXZFOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGE4DAMBZHA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
Reverts #1068
I'm reverting this for now. If the loop-back address isn't on the approved list, we need to get that added.
The pic's deleted with the password obscured shouldn't be deleted without @John-Hart approval. Our mandate is to warn and recommend the most secure authentication flow. IIS Mgr doesn't have a mechanism to store secrets in a key vault AFAIK.
We have too many customers using IIS and IIS Mgr to just delete all those images.