Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to live #1074

Open
wants to merge 23 commits into
base: live
Choose a base branch
from
Open

Merge to live #1074

wants to merge 23 commits into from

Conversation

Rick-Anderson
Copy link
Contributor

No description provided.

Rick-Anderson and others added 22 commits May 23, 2024 17:46
* Update url-rewrite-module-video-walkthrough.md

* a

a
* Delete dead content

* Update iis/TOC.yml

* Delete dead content

* Delete dead content

* Delete dead content
Moved the picture down so that it matches what end users should see after step 7 and 8.
* IIS-docs: SFI Image sev 0-2 Fixes

* Added more non-referenced images for deletion

* finished fixing all sev 2
* Fixed broken links in Learn Online Build Report.

* Fixed two more links.

---------

Co-authored-by: Lex Li <[email protected]>
* Update using-custom-rewrite-providers-with-url-rewrite-module.md

The download link is invalid. Deleted it.
Third part saved download link: https://web.archive.org/web/20200801000000id_/download.microsoft.com/download/3/9/E/39E30671-7AD2-4902-B56B-C300D862595E/RewriteExtensibility.msi
Check if there is an official download way.

* Update iis/extensions/url-rewrite-module/using-custom-rewrite-providers-with-url-rewrite-module.md

Linked to URL Rewrite 2.1 module as has been suggested previously by IIS team's Sam Wu.

---------

Co-authored-by: Wade Pickett <[email protected]>
adding examples and making modifications

Co-authored-by: EsraShrouf <[email protected]>
* SFI images IIS-docs sev1-2 updates only

* Re-evaluated with new guidelines and high bar for change for fictitious settings required for topics
@Rick-Anderson Rick-Anderson requested a review from a team as a code owner November 15, 2024 19:19
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but see my note on file delection for iis/extensions/url-rewrite-module/url-rewrite-module-video-walkthrough.md
The URL Rewriter video still exists but in a different location:
https://learn.microsoft.com/en-us/shows/iis-net-site-videos/url-rewrite-module-video-walkthrough

It was not clear to me if the topic was being deleted due to the missing video (which is not really missing but moved) or for some other reason.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this video topic file was being deleted because the video was lost, I think the video moved to here:
https://learn.microsoft.com/en-us/shows/iis-net-site-videos/url-rewrite-module-video-walkthrough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually please disregard this. Although the video was moved and available it is damaged, it only has a starter image and then only the sound plays with a blank video for the rest, making it useless.

* Update ihttprequest-getclientcertificate-method.md

The link for HTTP_SSL_CLIENT_CERT_INFO structure was broken. So fixed the link

* Update ihttprequest-getclientcertificate-method.md

---------

Co-authored-by: Rick Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants