Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-assigned-device-group.md #4664

Merged
merged 17 commits into from
Nov 20, 2024

Conversation

andrew-s-taylor
Copy link
Contributor

@andrew-s-taylor andrew-s-taylor commented Nov 7, 2024

Changed from Deprecated AzureAD module to MgGraph

MAXADO-9227169

Changed from Deprecated AzureAD module to MgGraph
Copy link
Contributor

@andrew-s-taylor : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 4fac133:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 77f5697:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 07678a7:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Add missing Microsoft.Graph.Authentication step plus adding more details
Copy link
Contributor

Learn Build status updates of commit bef3774:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Update New-MgServicePrincipal link
Copy link
Contributor

Learn Build status updates of commit 2aca73f:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 05ecbd3:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Add error message that can occur if service principal is already added
Copy link
Contributor

Learn Build status updates of commit 34cc721:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Adding additional error message plus fixing formatting
Copy link
Contributor

Learn Build status updates of commit b6a46ba:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit ac5d628:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit e0dc4e0:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 686b1d0:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Grammer correction
Copy link
Contributor

Learn Build status updates of commit 9ff8da5:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

Adding details to agree to install components
Copy link
Contributor

Learn Build status updates of commit 08c9e5b:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 2fe0e61:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 576ba0d:

✅ Validation status: passed

File Status Preview URL Details
autopilot/includes/create-assigned-device-group.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

@frankroj
Copy link
Contributor

Thank you for the contribution @andrew-s-taylor. This was actually on our radar to update but I hadn't gotten around to it. I did make some changes to your contributions including adding a missing step and adding more details, especially if the commands are being run for the first time on a device. This should go live sometime tomorrow.

@frankroj frankroj merged commit 0999f45 into MicrosoftDocs:main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants