Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notes to corporate identifier #4688

Closed
wants to merge 2 commits into from

Conversation

VigneshMitsume
Copy link
Contributor

Below sentence in the corporate identifier passage confuses the user who blocks personal windows device enrollment in their tenant. Hence adding notes.

===========
Corporate identifiers for Windows is optional for Windows Autopilot device preparation. Corporate identifiers for Windows isn't required for a Windows Autopilot device preparation deployment to work.

Below sentence in the corporate identifier passage confuses the user who blocks personal windows device enrollment in their tenant. Hence adding notes.

===========
 Corporate identifiers for Windows is optional for Windows Autopilot device preparation. Corporate identifiers for Windows isn't required for a Windows Autopilot device preparation deployment to work. 
===========
Copy link
Contributor

@VigneshMitsume : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit fce5d75:

✅ Validation status: passed

File Status Preview URL Details
autopilot/device-preparation/overview.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit ff02ba5:

✅ Validation status: passed

File Status Preview URL Details
autopilot/device-preparation/overview.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@frankroj
Copy link
Contributor

frankroj commented Dec 9, 2024

Thank you for your contribution @VigneshMitsume. However, two things:

  1. Since you are an internal Microsoft employee, please use the internal Microsoft repo instead of the public repo for this submission. Reach out to me directly if you need more info.

  2. I think it's a given that if corporate identifiers are required in the environment, then it's also required for APDP. There's no need to spell that out. It's a logical conclusion. The main thing being pointed out in the docs is that enabling corporate identifiers isn't required for APDP. We can't start getting into pointing out every little detailed configuration, especially one that is logically obvious, because then that starts cluttering the docs. Instead of adding a note, I would be open to slightly rewording the existing sentence to something like below:

Corporate identifiers for Windows are optional for Windows Autopilot device preparation as long as they aren't already required in the environment.

If you are interested in making this change, please submit in the internal repo.

@frankroj frankroj closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants