Update buffer size notes for (Sym)FindExecutableImage(Ex)(W) #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason this function passes MAX_PATH + 1 as the size of ImageFilePath to GetFullPathName, which dutifully clears MAX_PATH + 1 characters and writes past the end of a MAX_PATH sized buffer
|
@microsoft-github-policy-service agree company="Magical Glamour Executables" Though one wonders how anyone can agree to term number 2 'before making a submission' if they're not shown the license until after it's been made |
|
@adeyblue : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
I scanned the dbghelp.h file and did not find a SAL annotation as you specify. Please provide this info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these functions assume a valid output buffer size of 261 characters (MAX_PATH+1).
The DbgHelp.h header has this information as SAL annotations (or whatever they're called this week) but it seems this information hasn't been migrated to the docs.