Skip to content

Correct application patterns for visual studio #10945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tonyhallett
Copy link
Contributor

Link to api for "default control button".
Replace "These buttons are mapped to shortcut keys by default" as they are not unless using MessageDialog.Show

#sign-off

Link to api for "default control button".
Replace "These buttons are mapped to shortcut keys **by default**" as they are not unless using [MessageDialog.Show](https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.platformui.messagedialog.show?view=visualstudiosdk-2022)
Copy link
Contributor

Learn Build status updates of commit 90a9835:

💡 Validation status: suggestions

File Status Preview URL Details
docs/extensibility/ux-guidelines/application-patterns-for-visual-studio.md 💡Suggestion Details

docs/extensibility/ux-guidelines/application-patterns-for-visual-studio.md

  • Line 384, Column 116: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /dotnet/api/system.windows.controls.button.isdefault?view=netframework-4.7.2
  • Line 394, Column 93: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /dotnet/api/system.windows.controls.button.isdefault?view=netframework-4.7.2
  • Line 394, Column 194: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /dotnet/api/system.windows.controls.button.iscancel?view=netframework-4.7.2

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

@tonyhallett : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@tonyhallett
Copy link
Contributor Author

I pinned the version given that VS extensibility is .NET Framework - although perhaps 4.72 was not correct.

@v-dirichards
Copy link
Contributor

@tinaschrepfer

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 7, 2025
preserve view to match framework version of visx templates
Copy link
Contributor

Learn Build status updates of commit d178c43:

✅ Validation status: passed

File Status Preview URL Details
docs/extensibility/ux-guidelines/application-patterns-for-visual-studio.md ✅Succeeded

For more details, please refer to the build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants