Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expands on the declarative alternative solution for Web Install #975
base: main
Are you sure you want to change the base?
Expands on the declarative alternative solution for Web Install #975
Changes from 8 commits
e887ddb
c4f27e7
d7b965b
80d1c79
cd538bd
ddaabc9
e3f8de5
7abd3db
c5345d3
38051d7
49a564e
7a9fe14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the TAG review, some of the feedback was this: "'Takes the user out of the current context.' is a downside, but the TAG currently disagrees that that's a downside and would need to be convinced. What data have you collected that shows that it's bad for users to have to visit a website before installing it? A "peek" UI like https://resources.arc.net/hc/en-"
You and I are in agreement that there exist potential dev benefits to allow the current context to be retained, but I don't think you've managed to provide an actual example here to demonstrate that. I just think we need to flush this point out a little further. They ask what data we have for our suggestion. We have at least one web developer (store.app) who's desired model would be to have the install occur without navigating away (in theory to facilitate multiple installations). TAG doesn't present data to the contrary. I don't think we necessarily need data, but flushing out realistic scenarios might help close this part of the conversation down.