Add Adrastia Prudentia for controlling supply & borrow caps #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.0.0-beta.2
- Reduces the size of the Comptroller contract
vminkov
reviewed
Jun 7, 2023
contracts/compound/Comptroller.sol
Outdated
| uint256 underlyingDecimals = 18; | ||
|
|
||
| // Try to get the underlying asset address (we use a staticcall b/c CEther doesn't have an underlying) | ||
| (bool success, bytes memory data) = cToken.staticcall(abi.encodeWithSignature("underlying()")); |
There was a problem hiding this comment.
after the refactoring from #638 is merged, the CEther/CToken will removed from the codebase in favour of CErc20, so these calls can be simplified
There was a problem hiding this comment.
Thanks for the speedy review, Veliko! I've simplified the calls for getting the underlying token address.
vminkov
reviewed
Jun 7, 2023
| * @author Tyler Loewen (TRILEZ SOFTWARE INC. dba. Adrastia) | ||
| * @notice A diamond extension that allows the Comptroller to use Adrastia Prudentia to control supply and borrow caps. | ||
| */ | ||
| contract ComptrollerPrudentiaCapsExt is DiamondExtension, ComptrollerV4Storage, ComptrollerErrorReporter { |
There was a problem hiding this comment.
looks like this extension does not need to inherit the ComptrollerErrorReporter
TRiLeZ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for using Adrastia Prudentia for controlling supply & borrow caps.
Task list
Type of change
High-level change(s) description - from the user's perspective
Adrastia Prudentia is a novel rate controller system that can be used to manage a variety of risk parameters. Prudentia improves security and user experience while streamlining risk management. Its key features are:
This PR uses Prudentia for controlling supply & borrow caps. Lenders and borrowers can expect more fluid changes as they won't have to wait for the vault's risk management team to perform updates; these updates can be automated. Tighter controls can also be employed as updates can be more frequent, allowing for greater protection of user collateral.
Risk management teams can expect to do less tedious work. Instead of manually changing supply & borrow caps as vault activity changes, they can continue monitoring the markets, making infrequent adjustments as necessary. They can also rest with more peace of mind as Prudentia's rate limiting and other controls protect the vault from human mistakes, such as missing a zero.
Note: Ultimately, the changes to the user's experience depend on how Prudentia is configured.