1.36.3 guard clause for init (missing sdkType)

1.36.3 guard clause for init (missing sdkType) Seen in sentry.io reports initialization of instance w/o sdkType defined.
MikalDev · Feb 11, 2021 · 53321bf · 53321bf
1 parent a9ff506
commit 53321bf
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 3 deletions.
diff --git a/dist/Spine-v1.36.3.c3addon b/dist/Spine-v1.36.3.c3addon
diff --git a/src/addon.json b/src/addon.json
@@ -3,7 +3,7 @@
   "type": "plugin",
   "name": "Spine",
   "id": "Gritsenko_Spine",
-  "version": "1.36.2",
+  "version": "1.36.3",
   "author": "Mikal and Igor Gritsenko",
   "website": "https://gritsenko.github.io/c3_spine_plugin",
   "documentation": "https://gritsenko.github.io/c3_spine_plugin",

diff --git a/src/c3runtime/instance.js b/src/c3runtime/instance.js
@@ -425,6 +425,17 @@
         }
 
         IsSpineReady() {
+            // Guard for case where sdkType does not exist (deleted on release)
+            if (this.sdkType === null || this.sdkType === undefined)
+            {
+                if (this.debug) console.warn('[Spine] IsSpineReady, sdkType not defined', this.sdkType);
+                if (globalThis.Sentry)
+                {
+                    globalThis.Sentry.captureException('[Spine] IsSpineReady, sdkType not defined:'+this.sdkType);
+                }
+                return false;
+            }
+
             if (this.isSkeletonLoaded) {
                 return true;
             }

diff --git a/src/c3runtime/spine-draw.js b/src/c3runtime/spine-draw.js
@@ -305,6 +305,6 @@ class SpineBatch {
 
 if (!globalThis.spineBatcher)
 {
-    console.log('[Spine] SpineBatcher init, 1.36.2');
+    console.log('[Spine] SpineBatcher init, 1.36.3');
     globalThis.spineBatcher = new SpineBatch();
 }
diff --git a/src/plugin.js b/src/plugin.js
@@ -3,7 +3,7 @@
     const C3 = self.C3;
 
     const PLUGIN_ID = "Gritsenko_Spine";
-    const PLUGIN_VERSION = "1.36.2";
+    const PLUGIN_VERSION = "1.36.3";
     const PLUGIN_CATEGORY = "general";
 
     const PLUGIN_CLASS = SDK.Plugins.Gritsenko_Spine = class SpinePlugin extends SDK.IPluginBase {