Add new filters to apply dashboards #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mikesch-mp Please feel free to contact me if you want to discuss the feature or if I can assist merging it. |
|
@Mikesch-mp are there any issues with this PR? Can I help to get it merged soon? |
1 similar comment
|
@Mikesch-mp are there any issues with this PR? Can I help to get it merged soon? |
|
@Mikesch-mp would be great to get any feedback. Are you interested in merging this feature, do you have other plans to improve the filtering or are there no plans to improve the filtering? |
phibos
force-pushed
the
feature/improve_filters
branch
from
06c1982 to
45c29fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new values to apply a dashboard. The first filter allows the use of the service name and the second allows to filter by the command name. Both filters can be used together and if both are given both have to match to apply a dashboard.
It is also possible to use a regex because both filters use
preg_match().If you like you can merge #272 first. I will do a rebase and fix it if there are any merge conflicts.