Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing_controller.dart #1792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhbdev
Copy link

@mhbdev mhbdev commented Nov 12, 2023

Solves #1789
This commit will affect AutoTabsRouter path stacking. If the user click on the back button and activeIndex is not homeIndex, then pops to previous active tab not homeIndex.

Solves Milad-Akarie#1789
This commit will affect AutoTabsRouter path stacking. If the user click on the back button and activeIndex is not homeIndex, then pops to previous active tab not homeIndex.
@mhbdev
Copy link
Author

mhbdev commented Nov 14, 2023

I think I have to consider another condition! Considering that the user has passed through these routes:

homeIndex is 0.

DashBoard -> homeIndex -> 2 -> 1 -> homeIndex -> 3 -> 4

On pop goes from 4 to 3 and then homeIndex and finally pop the whole app.

I have to check if there is no previous route at all, then pop the whole app if the user is on homeIndex.

@Milad-Akarie
Copy link
Owner

Hey @mhbdev I haven't tested the code yet but from a first a glance I think it might cause a non-ending loop since setActiveRoute sets the previous index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants