#25 [feat] GET - 글 해당 댓글 리스트 조회 구현 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
Comment내부 연관관계를User에서WriterName으로 변경했습니다!WriterName으로 변경하는게 적합하다고 판단했습니다! 혹시 의견있으면 남겨주세요!PostAuthenticateService와PostService분리CommentService에서 해당 post에 대한 댓글 권한이 있는지 확인하는 플로우에서PostService를 참조해야 했는데, 이미PostService에서CommentService를 참조하고 있어순환 참조 문제가 발생하고, 또한 PostService의 역할이 커지는 것 같아 검증과 관련된 메소드는PostAuthenticateService를 따로 두어 역할을 분리해주었습니다.To Reviewers 📢