Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#504 [feat] 글모임 정보 통합 제공 API 구현 #505

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Conversation

sohyundoh
Copy link
Member

✒️ 관련 이슈번호

Key Changes 🔑

  1. 슬랙에서 API 통합 논의가 나와서 먼저 구현을 해놓았습니다! 이 후에 사용하지 않는 API를 삭제하는 방향으로 수정하면 될 것 같습니다!
  2. 그리고 logging에 info level(예외가 아닌 요청)도 로깅할 수 있게(tps를 보는데 효과적) 수정하면서 logging의 경우 presentation 계층(왜냐하면 요청이 들어오면서 로깅시작, 끝나면 로깅 종료이기 때문)에 속한다고 판단하여 예외 로깅 및 global exception handler(사용자에게 예외를 보내기 위함) 또한 api 모듈로 이동하였습니다.

To Reviewers 📢

@sohyundoh sohyundoh added the high label Aug 27, 2024
@sohyundoh sohyundoh self-assigned this Aug 27, 2024
Copy link
Contributor

@parkheeddong parkheeddong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 확인했습니다 고생하셨습니다 !

return MoimMostCuriousWriterResponse.of(writers);
}

public MoimMostCuriousWriterResponse getMoistCuriousWritersOfMoimForTotal(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5) Most 오타가 난것 같슴니다!

@sohyundoh sohyundoh merged commit 9766d07 into develop Sep 2, 2024
1 check passed
@sohyundoh sohyundoh deleted the feat/#504 branch September 2, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 글모임 정보 API 통합
2 participants