Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#50 [feat] 글모임 최신 글감 GET #51

Merged
merged 7 commits into from
Jan 11, 2024
Merged

#50 [feat] 글모임 최신 글감 GET #51

merged 7 commits into from
Jan 11, 2024

Conversation

sohyundoh
Copy link
Member

✒️ 관련 이슈번호

Key Changes 🔑

  1. 스웨거 작성하였습니다.
  2. createdAt 기준으로 정렬 후 가장 위에 있는 Topic을 가져오는 query문은 QueryDSL을 사용하였습니다.
  3. 도메인 Topic에 있는 topic 필드가 도메인명과 충돌해서 content로 변경하였습니다!

To Reviewers 📢

  • 수정사항 있으면 알려주세요!

@sohyundoh sohyundoh self-assigned this Jan 10, 2024
Copy link
Contributor

@parkheeddong parkheeddong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생하셨습니다 !

@@ -37,7 +38,8 @@ SuccessResponse<ContentListResponse> getTopicsFromMoim(
@ApiResponses(
value = {
@ApiResponse(responseCode = "200", description = "사용자의 권한이 확인되었습니다."),
@ApiResponse(responseCode = "403", description = "사용자 검증 토큰이 유효하지 안습니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))
@ApiResponse(responseCode = "403", description = "사용자 검증 토큰이 유효하지 안습니다.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 요기 오타가 생긴거 같아요!

.where(topic.moim.eq(moim))
.orderBy(topic.createdAt.desc())
.fetchFirst());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryDSL을 사용하니까 가독성이 너무 좋네요..

@sohyundoh sohyundoh merged commit 893c662 into develop Jan 11, 2024
1 check failed
@sohyundoh sohyundoh deleted the feat/#50 branch January 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 글 모임 뷰 - 최신 글감 GET
2 participants