Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1664 - Thirsty of better error management #207

Merged
merged 1 commit into from
May 30, 2024

Conversation

johnmarcou
Copy link
Collaborator

@johnmarcou johnmarcou commented May 27, 2024

This PR bring a better error message handling when the remote files are not downloadable.

It also removes the deprecated commented lines in the values.yaml to avoid confusion.

@johnmarcou johnmarcou self-assigned this May 29, 2024
@johnmarcou johnmarcou marked this pull request as ready for review May 29, 2024 15:12
Copy link
Collaborator

@simisimis simisimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections on my end

@johnmarcou johnmarcou force-pushed the jm-pm-1664-error-on-missing-file branch from 728fdfa to 75783dd Compare May 30, 2024 20:23
@johnmarcou johnmarcou force-pushed the jm-pm-1664-error-on-missing-file branch from 75783dd to 1bcb90e Compare May 30, 2024 20:25
@johnmarcou johnmarcou merged commit a0d253a into main May 30, 2024
1 check passed
@johnmarcou johnmarcou deleted the jm-pm-1664-error-on-missing-file branch May 30, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants