Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the Delegation Backend Unit Test soft fail #14475

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

SanabriaRusso
Copy link
Collaborator

Explain your changes:

  • Made the delegation backend unit test optional by including the soft_fail parameter to true in the step command.

Explain how you tested your changes:

  • Executing a CI run and confirming that even if the unit test fails it does not impact the overall job results.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@SanabriaRusso SanabriaRusso requested a review from a team as a code owner November 1, 2023 16:32
@SanabriaRusso
Copy link
Collaborator Author

!ci-build-me

@stevenplatt stevenplatt merged commit 4aee1bd into develop Nov 1, 2023
2 checks passed
@stevenplatt stevenplatt deleted the luis-buildkite-onboarding branch November 1, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants