Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Delegation Backend unit test and reference to container image #14485

Merged

Conversation

SanabriaRusso
Copy link
Collaborator

Explain your changes:

  • Removed non required test's Dhall and container reference from Buildkite's Constants.
  • The Container image was removed from the registry.

Explain how you tested your changes:

  • A successful CI run is expected

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@SanabriaRusso SanabriaRusso requested a review from a team as a code owner November 2, 2023 16:47
@mrmr1993 mrmr1993 force-pushed the luis-removing-delegation-backend-unit-test-develop branch from 3ddd11d to 016cb2e Compare March 6, 2024 21:09
@SanabriaRusso SanabriaRusso requested review from a team as code owners March 6, 2024 21:09
@mrmr1993
Copy link
Member

mrmr1993 commented Mar 6, 2024

!ci-build-me

@mrmr1993
Copy link
Member

mrmr1993 commented Mar 7, 2024

!ci-build-me

@mrmr1993 mrmr1993 merged commit 13643e7 into develop Mar 7, 2024
58 checks passed
@mrmr1993 mrmr1993 deleted the luis-removing-delegation-backend-unit-test-develop branch March 7, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants