Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the generation of kimchi parameters to use static function for Poseidon hashing #14921

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Jan 18, 2024

o1js: o1-labs/o1js#1378
bindings: o1-labs/o1js-bindings#237

See the o1js PR for a complete description of this work.

@MartinMinkov MartinMinkov force-pushed the perf/poseidon-hash-bottleneck branch from 0512ad7 to 94ae65b Compare January 19, 2024 00:06
@MartinMinkov MartinMinkov marked this pull request as ready for review January 19, 2024 00:34
@MartinMinkov MartinMinkov requested a review from a team as a code owner January 19, 2024 00:34
Copy link
Contributor

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know static_params existed :D

@MartinMinkov
Copy link
Contributor Author

!ci-build-me

@dannywillems
Copy link
Member

ocaml/opam-repository#25099 it has been updated in opam-repository 3 hours ago

@mrmr1993 mrmr1993 merged commit f4e67fe into o1js-main Jan 24, 2024
1 of 2 checks passed
@mrmr1993 mrmr1993 deleted the perf/poseidon-hash-bottleneck branch January 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants