Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rampup] Add 'merges cleanly to rampup' CI job #14947

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

mrmr1993
Copy link
Member

This is #14895 against rampup

@mrmr1993 mrmr1993 requested review from a team as code owners January 23, 2024 20:28
@mrmr1993
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

Looks like there are some changes not related to the CI job in this PR @mrmr1993 Are these needed?

@mrmr1993
Copy link
Member Author

!approved-for-mainnet

@mrmr1993
Copy link
Member Author

Are these needed?

They come from the merge compatible -> rampup. The goal of this PR is to unblock #14895, which will make PRs like this unnecessary

@mrmr1993
Copy link
Member Author

Concretely, this PR is #14954 and #14895 combined.

@deepthiskumar
Copy link
Member

They come from the merge compatible -> rampup. The goal of this PR is to unblock #14895, which will make PRs like this unnecessary

Oh ok. I just created a one for merging compatible changes #14954 and subsequent PRs for berkeley and develop. Once the berkeley and develop ones land you can merge this and I can close #14954

@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!approved-for-mainnet

@mrmr1993
Copy link
Member Author

This is identical to the already-approved PR #14895. Force-merging to expedite.

@mrmr1993 mrmr1993 merged commit 2987b2c into rampup Jan 24, 2024
1 of 2 checks passed
@mrmr1993 mrmr1993 deleted the merges-cleanly-to-rampup-RAMPUP branch January 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants