Dkijania/merge compatible into user command remove #16686
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be useful to differentiate a proof as in wire types and a proof as a reference to cache.
…arrying_data-in-mina_wire_types' into georgeee/add-missing-ocamlformat
…-proof_cache_tag' into georgeee/proof-cache-tag-base
…roof_carrying_data-in-transaction_snark' into georgeee/proof-cache-tag-base
…e-internals-of-transaction-snark' into georgeee/proof-cache-tag-base
…orphize-some-transaction-snark-functions' into georgeee/proof-cache-tag-base
…e-sexp-from-available-job' into georgeee/proof-cache-tag-base
…e-sexp-from-blocks' into georgeee/proof-cache-tag-base
…e-derivations-from-transaction_snark_work' into georgeee/proof-cache-tag-base
…transaction-snark-work-checked-different' into georgeee/proof-cache-tag-base
…fields-of-transaction-snark-work-checked' into georgeee/proof-cache-tag-base
…ojson-outside-of-mina-block-stable' into georgeee/proof-cache-tag-base
…ve-sexp-from-snark-pool' into georgeee/proof-cache-tag-base
…ers-in-best-tip-prover-verify' into georgeee/proof-cache-tag-base
…ge-type-of-best-tip-lru-element' into georgeee/proof-cache-tag-base
…lify-persistent-frontier-db-types' into georgeee/proof-cache-tag-base
…ve-equal-from-mina_block' into georgeee/proof-cache-tag-base
…get_root_hash-in-persistent-frontier' into georgeee/proof-cache-tag-base
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step for removing the equality in the implementation as well.
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step for removing the equality in the implementation as well.
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step for removing the equality in the implementation as well.
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step for removing the equality in the implementation as well.
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step for removing the equality in the implementation as well.
…into georgeee/proof-cache-tag-base-for-last
This would allow caching of ledger proofs on disk once the LMDB backend for Proof_cache_tag.t is added.
In Transaction_hash.User_command_with_valid_signature
Remove Transaction_hash.User_command_with_valid_signature.Stable
Define stable and regular types separately
Define stable and regular types separately
Contains a few temporary edits to be unwinded later.
Plus: define `generate` and `unwrap` as `Fn.id` in `zkapp_command.ml` and use these definitions in all of the types that depend on `Zkapp_command.t`.
This interface file is an exact copy of the transaction_witness.ml, hence it's redundant to keep it.
This commit is a no-op change, but prepares for the future switch of types.
This is a no-op change which prepares codebase for future switch of zkapp_command types.
This is a no-op modification that is required for future switch of zkapp_command types.
Remainder of changes in preparation of removing hashes from Zkapp_command.Stable.Latest.t.
Use a no-hash representation.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome 👋
Thank you for contributing to Mina! Please see
CONTRIBUTING.mdif you haven'tyet. In that doc, there are more details around how to start our CI.
If you cannot complete any of the steps below, please ask for help from a core
contributor.
Incomplete Work
We feel it's important that everyone is comfortable landing incomplete projects
so we don't keep PRs open for too long (especially on develop). To do this we
don't want to forget that something is incomplete, don't want to be blocked on
landing things, and we don't want to land anything that breaks the daemon. We
don't want to forget to test the incomplete things whenever they are completed,
and finally we want to clean up after ourselves: any temporary cruft gets
completely removed before a project is considered done.
To achieve the above, we wish to keep track of incomplete work using a draft of
the release notes. We can share this part of the current draft at anytime with
external contributors. Moreover, we will review this draft during hardforks.
To ship incomplete work, put it behind feature flags -- prefer a runtime
CLI/daemon-config-style flag if possible, and only if necessary fallthrough to
compile time flags. Note that if you put code behind a compile time flag, you
must ensure that CI is building all possible code paths. Don't land something
that doesn't build in CI.
PLEASE DELETE EVERYTHING ABOVE THIS LINE
Explain your changes:
*
Explain how you tested your changes:
*
Checklist: