Better SDK34 support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… :provider (that is building clean as of this changeset)
…se 1.9.1 breaks metadata compatibility with AGP 7.4.1
…l need attention, but :app and :provider should build now.
…kHttp to latest 3.x
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
Wording++ by @sumitramanga 👍 Co-authored-by: Sumitra Manga <[email protected]>
Co-authored-by: Sumitra Manga <[email protected]>
Co-authored-by: Sumitra Manga <[email protected]>
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
reviewed
Nov 6, 2023
sumitramanga
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
LGTM! 💯 Would you like me to test on my end or are you sweet? @TheRealAgentK
|
I get what looks like warnings when pulling down the branch and cleaning the project - Does this happen on your end? |
|
One of the warnings look related to Gradle upgrade which yo mentioned would be done in a separate PR. That can be ignored for now |
Yeah, that's because of Gradle deprecations for 8. |
|
The build itself succeeded on my local machine 👍🏽 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General SDK34 compatibility
Description 📝
This PR is to add SDK 34 compatibility to the raygun4android provider. We had a user coming through mentioning that they can't use raygun4android at all on their project, due to the forward compatibility not working well. So we've decided to jut update the SDK to version 34, meeting the project requirement.
Type of change
Updates
:providerand:appmodules work correctly with SDK34 and with more modern dependenciesTest plan 🧪
:providerfrom clean, build:appAuthor to check 👓
Reviewer to check ✔️
- [ ] Appropriate tests have been written (code comments, internal docs)- N/A right nowCaveats: