Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GH Action title check #10

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci: GH Action title check #10

merged 1 commit into from
Jul 17, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jul 16, 2024

ci: GH Action title check

Description 📝

  • Purpose: Adds GitHub Action that checks PR title validity
  • Approach: Copied over from raygun4node

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • Copied file from raygun4node

Screenshots 📷

  • None

Test plan 🧪

  • None

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran requested review from sumitramanga, a team, nikz, PanosNB and TheRealAgentK and removed request for a team July 16, 2024 07:23
Copy link
Contributor

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheRealAgentK
Copy link
Contributor

@miquelbeltran Quick question - this action definition is totally neutral re technology, right? So - I should be able to grab it and stick it into the Java repo as is?

@TheRealAgentK
Copy link
Contributor

It looks like the build is failing due to some unrelated issue, @miquelbeltran

@sumitramanga
Copy link
Collaborator

Same here, solved in #12 I think @TheRealAgentK

@miquelbeltran
Copy link
Contributor Author

@miquelbeltran Quick question - this action definition is totally neutral re technology, right? So - I should be able to grab it and stick it into the Java repo as is?

Yes, I have copied the file from raygun4node. It could be copied to every Raygun repo.

It looks like the build is failing due to some unrelated issue, @miquelbeltran

As mentioned in the other PRs, the test CI job and the warnings are being fixed in different PRs.

@miquelbeltran miquelbeltran merged commit 906be1f into main Jul 17, 2024
2 of 3 checks passed
@miquelbeltran miquelbeltran deleted the miquelbeltran-patch-1 branch July 17, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants