feat: #13 Support JavaScript stack trace #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: dotnet formatting * simplify job * test break formatting * fix format * dotnet format
src/Raygun.Samples.Blazor.WebAssembly/Raygun.Samples.Blazor.WebAssembly.csproj
Show resolved
Hide resolved
| /// Example: "causeErrors@http://localhost:5010/myfunctions.js:4:9" | ||
| /// </summary> | ||
| /// <param name="frame">JavaScript stack trace</param> | ||
| internal StackTraceDetails(string frame) |
There was a problem hiding this comment.
If you are going to use RegEx here you should REALLY consider using .NET 8 regex attributes to leverage codegen to optimize execution.
This is the slowest way to do regex. You'll create a new RegEx instance for every line of every stack trace, which on deep stack traces will have a significant negative impact on allocations & performance.
There was a problem hiding this comment.
Thanks! created an issue for it #31
miquelbeltran
added a commit
that referenced
this pull request
Jul 30, 2024
…ethod WIP attach user details add user details to record exception async custom IRaygunUserManager on example project dotnet format wip feat: #13 Support JavaScript stack trace (#25) * add ApiKey to appsettings.json in tests * apply naming suggestions by Rider IDE * inject mocked IJSRuntime * HttpMethod should be String not type HttpMethod * wip fixing tests * simple fix * fix tests * cleanup * cleanup * test cleanup * more cleanup * restore file * ci: dotnet formatting * simplify job * test break formatting * fix format * dotnet format * fixing warnings * fix warnings * 5 warnings * ci: Code formatting (#7) * ci: dotnet formatting * simplify job * test break formatting * fix format * dotnet format * fix acronym formatting * dotnet format * refactor: remove .NetCore from Raygun.NetCore.Blazor * WIP * fix visibility after refactor * more refactor * WIP * implement basic JS stacktrace parsing * implement tests * cleanup * remove TODOs * remove console log * fix merge errors * remove console.writeline oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: #13 Support JS Stack Trace
Description 📝
In the
ErrorDetailsconstruction, check if the exception is of typeWebIDLException, and optain the extra JavaScript stack trace information.Then, parse this stack trace into
StackTraceDetails..NetCorefrom namespace #24Type of change
Updates
ErrorDetailsto handle JS and Dotnet exception parsing.StackTraceDetailsconstructor for JavaScript traces.Screenshots 📷
Example of captured stacktrace from JavaScript:
Test plan 🧪
Author to check 👓
Reviewer to check ✔️