Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improvements in CI workflow #60

Merged
merged 16 commits into from
Nov 24, 2024
Merged

ci: Improvements in CI workflow #60

merged 16 commits into from
Nov 24, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Nov 22, 2024

ci: Improvements in CI workflow

Description 📝

Type of change

  • CI fix

Updates

  • Switch global dotnet version to latest 9.0.100
  • Upgrade dependencies to minimum requirement
  • Split dotnet build and dotnet test into different steps for each project
    • each step is marked as continue-on-error: true so it won't block the rest of the workflow job

Test plan 🧪

  • CI should pass ✔️

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran changed the title ci: Fixing MAUI CI Build ci: Improvements in CI workflow Nov 22, 2024
@miquelbeltran miquelbeltran marked this pull request as ready for review November 22, 2024 10:34
@miquelbeltran
Copy link
Contributor Author

My theory on why it failed to build is that for some reason 8.0.404 had this config error (not being able to find the Android framework), as the builds still worked on 8.0.403. I wasn't able to specify the exact version I wanted on CI. Switching to 9.0.x (9.0.100) fixed the build issue.

This shouldn't affect customers or any future releases, but requires that me (and anyone developing on this project) uses the latest stable Visual Studio / .Net SDK.

@@ -13,7 +13,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just want to confirm though that given we're now using the .NET 9 SDK that we're still releasing a .NET 8 library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target framework remains net8.0 in the csproj TargetFrameworks>net8.0;</TargetFrameworks>, so my understanding is that it all still builds as .net 8 library, even if we use SDK 9 to build it.

@ProRedCat
Copy link

Thanks for fixing this!!

@miquelbeltran miquelbeltran merged commit 5a16791 into main Nov 24, 2024
10 checks passed
@miquelbeltran miquelbeltran deleted the miquelbeltran-patch-1 branch November 24, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: MAUI Sample project android configuration error on GitHub Actions
2 participants