-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Improvements in CI workflow #60
Conversation
My theory on why it failed to build is that for some reason 8.0.404 had this config error (not being able to find the Android framework), as the builds still worked on 8.0.403. I wasn't able to specify the exact version I wanted on CI. Switching to 9.0.x (9.0.100) fixed the build issue. This shouldn't affect customers or any future releases, but requires that me (and anyone developing on this project) uses the latest stable Visual Studio / .Net SDK. |
@@ -13,7 +13,7 @@ jobs: | |||
- name: Setup .NET | |||
uses: actions/setup-dotnet@v4 | |||
with: | |||
dotnet-version: 8.0.x | |||
dotnet-version: 9.0.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just want to confirm though that given we're now using the .NET 9 SDK that we're still releasing a .NET 8 library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target framework remains net8.0 in the csproj TargetFrameworks>net8.0;</TargetFrameworks>
, so my understanding is that it all still builds as .net 8 library, even if we use SDK 9 to build it.
Thanks for fixing this!! |
ci: Improvements in CI workflow
Description 📝
Type of change
Updates
dotnet build
anddotnet test
into different steps for each projectcontinue-on-error: true
so it won't block the rest of the workflow jobTest plan 🧪
Author to check 👓
Reviewer to check ✔️