Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Code formatting #7

Merged
merged 5 commits into from
Jul 17, 2024
Merged

ci: Code formatting #7

merged 5 commits into from
Jul 17, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Jul 16, 2024 •
edited
Loading

ci: Code formatting

Description 📝

  • Purpose: Detect formatting errors
  • Approach: Use GH Actions

Depends on: #6

When the format is wrong:

image

After fixing the format:

image

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

  • formatted all code with dotnet format.
  • created GitHub action workflow

Screenshots 📷

  • None

Test plan 🧪

  • None

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@miquelbeltran miquelbeltran changed the base branch from main to 4-fix-tests July 16, 2024 07:17
@miquelbeltran miquelbeltran requested review from a team, nikz, TheRealAgentK, PanosNB and sumitramanga and removed request for a team July 16, 2024 07:22
TheRealAgentK
TheRealAgentK approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on a high level

@miquelbeltran miquelbeltran merged commit 19b3229 into 4-fix-tests Jul 17, 2024
2 checks passed
@miquelbeltran miquelbeltran deleted the code-formatting branch July 17, 2024 04:54
miquelbeltran added a commit that referenced this pull request Jul 17, 2024
@miquelbeltran
test: fix tests (#6)
9143caf 
* add ApiKey to appsettings.json in tests

* apply naming suggestions by Rider IDE

* inject mocked IJSRuntime

* HttpMethod should be String not type HttpMethod

* wip fixing tests

* simple fix

* fix tests

* cleanup

* cleanup

* test cleanup

* more cleanup

* restore file

* ci: Code formatting (#7)

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format
miquelbeltran added a commit that referenced this pull request Jul 24, 2024
@miquelbeltran
fix: #9 Fix warnings (#12)
08258d4 
* add ApiKey to appsettings.json in tests

* apply naming suggestions by Rider IDE

* inject mocked IJSRuntime

* HttpMethod should be String not type HttpMethod

* wip fixing tests

* simple fix

* fix tests

* cleanup

* cleanup

* test cleanup

* more cleanup

* restore file

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fixing warnings

* fix warnings

* 5 warnings

* ci: Code formatting (#7)

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fix acronym formatting

* dotnet format

* revert removing underscores
miquelbeltran added a commit that referenced this pull request Jul 29, 2024
@miquelbeltran
refactor: #21 Remove .NetCore from namespace (#24)
37659e7 
* add ApiKey to appsettings.json in tests

* apply naming suggestions by Rider IDE

* inject mocked IJSRuntime

* HttpMethod should be String not type HttpMethod

* wip fixing tests

* simple fix

* fix tests

* cleanup

* cleanup

* test cleanup

* more cleanup

* restore file

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fixing warnings

* fix warnings

* 5 warnings

* ci: Code formatting (#7)

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fix acronym formatting

* dotnet format

* refactor: remove .NetCore from Raygun.NetCore.Blazor

* WIP

* fix visibility after refactor

* more refactor

* fix merge errors

* docs: update README.md
miquelbeltran added a commit that referenced this pull request Jul 29, 2024
@miquelbeltran
feat: #13 Support JavaScript stack trace (#25)
37d4a26 
* add ApiKey to appsettings.json in tests

* apply naming suggestions by Rider IDE

* inject mocked IJSRuntime

* HttpMethod should be String not type HttpMethod

* wip fixing tests

* simple fix

* fix tests

* cleanup

* cleanup

* test cleanup

* more cleanup

* restore file

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fixing warnings

* fix warnings

* 5 warnings

* ci: Code formatting (#7)

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fix acronym formatting

* dotnet format

* refactor: remove .NetCore from Raygun.NetCore.Blazor

* WIP

* fix visibility after refactor

* more refactor

* WIP

* implement basic JS stacktrace parsing

* implement tests

* cleanup

* remove TODOs

* remove console log

* fix merge errors

* remove console.writeline
miquelbeltran added a commit that referenced this pull request Jul 30, 2024
@miquelbeltran
inject user manager, allow to pass user details to record exception m…
2302295 
…ethod

WIP attach user details

add user details to record exception async

custom IRaygunUserManager on example project

dotnet format

wip

feat: #13 Support JavaScript stack trace (#25)

* add ApiKey to appsettings.json in tests

* apply naming suggestions by Rider IDE

* inject mocked IJSRuntime

* HttpMethod should be String not type HttpMethod

* wip fixing tests

* simple fix

* fix tests

* cleanup

* cleanup

* test cleanup

* more cleanup

* restore file

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fixing warnings

* fix warnings

* 5 warnings

* ci: Code formatting (#7)

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fix acronym formatting

* dotnet format

* refactor: remove .NetCore from Raygun.NetCore.Blazor

* WIP

* fix visibility after refactor

* more refactor

* WIP

* implement basic JS stacktrace parsing

* implement tests

* cleanup

* remove TODOs

* remove console log

* fix merge errors

* remove console.writeline

oops
miquelbeltran added a commit that referenced this pull request Aug 2, 2024
@miquelbeltran
feat: #27 Internal RaygunLogger (#28)
7ba47e8 
* add ApiKey to appsettings.json in tests

* apply naming suggestions by Rider IDE

* inject mocked IJSRuntime

* HttpMethod should be String not type HttpMethod

* wip fixing tests

* simple fix

* fix tests

* cleanup

* cleanup

* test cleanup

* more cleanup

* restore file

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fixing warnings

* fix warnings

* 5 warnings

* ci: Code formatting (#7)

* ci: dotnet formatting

* simplify job

* test break formatting

* fix format

* dotnet format

* fix acronym formatting

* dotnet format

* refactor: remove .NetCore from Raygun.NetCore.Blazor

* WIP

* fix visibility after refactor

* more refactor

* fix merge errors

* docs: update README.md

* feat: Internal RaygunLogger

* cleanup

* cleanup post-merge

* cleanup logger implementation

* add logger to readme

* Improve RaygunLogger implementation

* optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAgentK TheRealAgentK TheRealAgentK approved these changes

@nikz nikz Awaiting requested review from nikz nikz was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@PanosNB PanosNB Awaiting requested review from PanosNB PanosNB was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@sumitramanga sumitramanga Awaiting requested review from sumitramanga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miquelbeltran @TheRealAgentK