SmithingTransformRecipe inproper itemmeta handling #53
Conversation
…splayName/enchantments/...)
| @@ -10,13 +10,15 @@ interface ItemRecipes { | |||
| val query: ItemRecipeQuery | |||
|
|
|||
| companion object : GearyAddonWithDefault<ItemRecipes> { | |||
| val recipes by lazy { default().query.registerRecipes() } | |||
There was a problem hiding this comment.
What is the purpose of moving here vs in install?
There was a problem hiding this comment.
mostly because before we would need to re-register to get all custom recipes
mostly forgot to remove it from some testing tbh
| val customRecipeResult = smithingTransformRecipes.filter { it.template.test(template) && it.addition.test(mineral) && it.base.itemStack.itemMeta?.persistentDataContainer?.decodePrefabs()?.firstOrNull() == inputGearyEntity }.firstOrNull()?.result | ||
| var recipeResultItem = (customRecipeResult ?: ItemStack.empty()).let { result?.toSerializable()?.toItemStack(it, EnumSet.of(SerializableItemStack.Properties.DISPLAY_NAME)) } | ||
|
|
||
| recipeResultItem = recipeResultItem?.editItemMeta { |
There was a problem hiding this comment.
Is this part necessary? the toItemStack should override as needed and keep the displayName if the ignored property is set. Is this maybe covering some case I'm not considering?
There was a problem hiding this comment.
newResult is applied ontop of oldResult
this is because otherwise the finalResult will have the prefabs from oldResult aka Diamond Sickle
this means however that the finalResult will have the displayname of oldResult aka Diamond Sickle, or if renamed the renamed
so it does indeed require to fix that afterwards from my testing to get correct behaviour
No description provided.