Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand NoteBlock BlockTracking to support up-to 1149 states #25

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Boy0000
Copy link
Contributor

@Boy0000 Boy0000 commented Mar 24, 2024

Replaces old logic and only reserves 1 blockstate for "vanilla noteblock"
With new instruments added, this will support 1149 custom blocks compared to old 750

@Boy0000 Boy0000 requested a review from 0ffz March 24, 2024 17:01
Copy link
Member

@0ffz 0ffz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't worked on this code much but lgtm. Feel free to merge

@Boy0000 Boy0000 merged commit cca1279 into develop Mar 28, 2024
1 check passed
@Boy0000 Boy0000 deleted the expand-noteblock-range branch March 28, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants