Skip to content

Commit

Permalink
Fixed uploader not having a skin variant at the start
Browse files Browse the repository at this point in the history
  • Loading branch information
@Sollace
Sollace committed Sep 30, 2024
1 parent f825898 commit 88207db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/com/minelittlepony/hdskins/client/gui/DualCarouselWidget.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class DualCarouselWidget implements Closeable, PlayerSkins.Posture, IText
private Pose pose = Pose.STAND;
private SkinType activeSkinType = SkinType.SKIN;

private Optional<SkinVariant> variant = Optional.empty();
private Optional<SkinVariant> variant = Optional.of(PlayerSkins.Posture.SkinVariant.DEFAULT);
private List<SkinVariant> skinVariants = new ArrayList<>(PlayerSkins.Posture.SkinVariant.VALUES);

private EquipmentSet activeEquipmentSet = HDSkins.getInstance().getDummyPlayerEquipmentList().getDefault();
Expand Down

4 comments on commit 88207db

@mattmess1221
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this field even need to be Optional?

@Sollace
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you ask me this already when the commit was made?

@mattmess1221
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so?

@Sollace
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an optional because the implemented interface uses Optional and I don't want to go rewriting a bunch of stuff.

    @Override
    public Optional<SkinVariant> getSkinVariant() {
        return variant;
    }

Please sign in to comment.