optifabric 2.3.5 #171
optifabric 2.3.5 #171
Conversation
|
Ornithe seems to be the same stuff plus the fix you mentioned which seems fine assuming it does in fact work |
|
ignoring the hash failure is for when running the Patcher to extract the _MOD jar from the binary class installer jar using a in-dev loom obfuscated mc jar that has Environment annotations etc in it and is not a bit-for-bit match. however those mixins never get applied since the configuration gets added afterwards and it's all in prelaunch anyway so I would have to bump the mixin phase or smth in the first place (that mixin is already in 1.8-1.12.2 & 1.13.2 subprojects, but installers also exist for modern 1.7.10 releases so I copied it over with hopes to get it working someday. (hoping this loader change helps FabricMC/fabric-loader#1064) |
|
targetClassName is just to clean up the diff from the ornithe branch, I'm not entirely sure what it does but I think it suppresses all errors now? (The old implementation was a little flawed iirc, the first one always got through.) |
sources:
tildejustin/optifabric@fd961db...legacy-fabric
tildejustin/optifabric@cd6dffa...ornithe
sorry for all the commits, the only thing for MCSR is fixing the 1.1 OptiFine releases (patching out the Signature attribute from xt.class), and that's in the ornithe branch only