Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle refactor + tests! #42

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Bernstern
Copy link
Contributor

Changelog

  • Added angle class to replace using double interchangeably for degrees + radians
  • Added tests ci job
  • Started adding tests
  • Fixed a small but with code that checked if the line between two poses crossed a circle / simplified the logic

@Bernstern Bernstern changed the base branch from main to kalmanFilter February 26, 2024 22:42
@Mineinjava
Copy link
Owner

the KalmanFilter branch is out of date. Can you change the PR to merge into main?

@Bernstern Bernstern changed the base branch from kalmanFilter to main February 27, 2024 22:38
…intIndex in Path.java and having Path.incrementCurrentPointIndex make all changes with a Path.isFinished helper to determine if all the path has been traversed
@Astr0clad
Copy link
Collaborator

Hey there! Could you please separate this PR into multiple? Ideally, it should be broken into one for the bugfix (highest priority) and then split the refactor of the Angle stuff into another PR. The tests are awesome, they've been on my to-do list for a while.

tl;dr: Unrelated bugfix/features should be separated please

@Mineinjava
Copy link
Owner

I'm going to start including some of this stuff in main incrementally. Pinging @Astr0clad

Pose2d p = points.get(i);
double distance = Math.sqrt(Math.pow(point.x - point.x, 2) + Math.pow(point.y - point.y, 2));
// TODO(Bernie, pre merge): Change to infinity
double minDistance = 10000, distance;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter because the min distance has to be lower than the first one

@Mineinjava Mineinjava self-requested a review August 4, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants