-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle refactor + tests! #42
base: main
Are you sure you want to change the base?
Conversation
the KalmanFilter branch is out of date. Can you change the PR to merge into main? |
…intIndex in Path.java and having Path.incrementCurrentPointIndex make all changes with a Path.isFinished helper to determine if all the path has been traversed
Hey there! Could you please separate this PR into multiple? Ideally, it should be broken into one for the bugfix (highest priority) and then split the refactor of the Angle stuff into another PR. The tests are awesome, they've been on my to-do list for a while. tl;dr: Unrelated bugfix/features should be separated please |
I'm going to start including some of this stuff in main incrementally. Pinging @Astr0clad |
Pose2d p = points.get(i); | ||
double distance = Math.sqrt(Math.pow(point.x - point.x, 2) + Math.pow(point.y - point.y, 2)); | ||
// TODO(Bernie, pre merge): Change to infinity | ||
double minDistance = 10000, distance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter because the min distance has to be lower than the first one
Changelog