Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parameter query settings into its own class #592

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Refactor parameter query settings into its own class #592

wants to merge 17 commits into from

Commits on Feb 15, 2024

  1. extract skip logic to their own methods

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    2debd93 View commit details
    Browse the repository at this point in the history

  2. Add manual disable too

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7889237 View commit details
    Browse the repository at this point in the history

  3. add manual_enable?

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6897644 View commit details
    Browse the repository at this point in the history

  4. extract QuerySettings class to contain logic to parse query string / … 

    …path
    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    64fda08 View commit details
    Browse the repository at this point in the history

  5. move skip paths into query_settings. move preauthorized logic into co… 

    …nfig
    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6447f35 View commit details
    Browse the repository at this point in the history

  6. move manual enable/disable

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b293550 View commit details
    Browse the repository at this point in the history

  7. move more methods to query_settings

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0128c81 View commit details
    Browse the repository at this point in the history

  8. push flamegraph settings to querysetting

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    430788e View commit details
    Browse the repository at this point in the history

  9. use query_params since we have already parsed it once instead of rege… 

    …xing tons of times
    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b1b13be View commit details
    Browse the repository at this point in the history

  10. more query settings

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    aedd2af View commit details
    Browse the repository at this point in the history

  11. move rest of things to query_settings

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c40b353 View commit details
    Browse the repository at this point in the history

  12. move allow_authorized logic into config, and remove unauthorized on M… 

    …iniProfiler
    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    855d854 View commit details
    Browse the repository at this point in the history

  13. run rubocop

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    021b8c3 View commit details
    Browse the repository at this point in the history

  14. correcting rebase

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f114b35 View commit details
    Browse the repository at this point in the history

  15. fix syntax

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b3e0b51 View commit details
    Browse the repository at this point in the history

  16. move query_settings to its own file. rubocop

    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4ac9e5a View commit details
    Browse the repository at this point in the history

  17. add back logic for handling results/snapshot/flamegraph. not sure why… 

    … i removed it in b293550
    @technicalpickles
    technicalpickles committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ad0e684 View commit details
    Browse the repository at this point in the history